Windows: Failed to modify resources

[jkudish]

Trying to build an app for Windows, from Windows, I get a "Failed to modify resources" error. See full log here

Seems to be related to Squirrel/Squirrel.Windows#488 and to electron-archive/grunt-electron-installer#96 though I am not positive it's the exact same error or not.

Despite the error, the build completes (but setup icon isn't set)

[jkudish]

FWIW I tried to follow the steps here but that didn't help.

[develar]

@jkudish Looks like icon is missed, see https://github.com/loopline-systems/electron-builder#in-short about icons (step 2 "icon.ico (Windows app icon)").

[jkudish]

I have the URL specified as per the documentation in my app/package.json not in the main development (root project level) package.json. Should it be in both?

[develar]

Under the hood we also set setupIcon (https://github.com/electronjs/windows-installer#usage) So, file build/icon.ico must exists. Do you have it?

[jkudish]

Yep, I have the file, and I have it in my config too:

"build": {
        "iconUrl": "https://app.theimagesalon.com/public/imgsalon.ico",
        "osx": { ... },
        "win": {
            "title": "The Image Salon",
            "publisher": "The Image Salon",
            "authors": "The Image Salon",
            "iconUrl": "https://app.theimagesalon.com/public/imgsalon.ico",
            "setupIcon": "build/icon.ico"
        }
    },

[jbleuzen]

I have the same error when building on a Win10 VM (x64). On another VM Win7 (ia32) we don't have this problem....

[jkudish]

Hmm good to know @jbleuzen -- I'll try a Win7 VM

[jkudish]

Tried in a Win7 VM (ia32). Same problem.

[jkudish]

Is the .ico supposed to be a certain size? Mine is 256x256 but wondering if that's the issue?

[jkudish]

Seems to be related to the VM setup. I tried again on a native windows machine from a friend and the app compiled without any problems there. Will try to figure out what about the VM is being problematic.

[develar]

Reopened — I am going to check some option values on electron-builder side because Squirrel.window produces unclear ugly error messages.

Yes, icon must be at least 256 size.