Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use desktop-file-validate to ensure that generated Desktop file is ok #2136

Closed
develar opened this issue Sep 30, 2017 · 1 comment
Closed

Use desktop-file-validate to ensure that generated Desktop file is ok #2136

develar opened this issue Sep 30, 2017 · 1 comment
Labels
feature linux nsis

Comments

@develar
Copy link
Member

develar commented Sep 30, 2017 •
edited
Loading

As electron-builder takes care about you. In all aspects.
@develar develar mentioned this issue Sep 30, 2017
Closed
@develar
Copy link
Member Author

develar commented Oct 2, 2017

Implemented, but for now only for AppImage. Simply because now we use official appimagetool and the only effort from our side — prebundle desktop-file-validate as part of AppImage bundle.

develar added a commit to develar/electron-builder that referenced this issue Oct 2, 2017
@develar
feat(AppImage): support type 2 image format
b445dc4 
Close electron-userland#2136, Close electron-userland#1998, Close electron-userland#832, Close electron-userland#993
develar added a commit to develar/electron-builder that referenced this issue Oct 2, 2017
@develar
feat(AppImage): support type 2 image format
c2602b9 
Close electron-userland#2136, Close electron-userland#1998, Close electron-userland#832, Close electron-userland#993
develar added a commit to develar/electron-builder that referenced this issue Oct 2, 2017
@develar
feat(AppImage): support type 2 image format
9f9a364 
Close electron-userland#2136, Close electron-userland#1998, Close electron-userland#832, Close electron-userland#993
develar added a commit to develar/electron-builder that referenced this issue Oct 2, 2017
@develar
feat(AppImage): support type 2 image format
878c469 
Close electron-userland#2136, Close electron-userland#1998, Close electron-userland#832, Close electron-userland#993
@develar develar closed this as completed in c8cd76a Oct 2, 2017
@iketheadore iketheadore mentioned this issue May 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature linux nsis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@develar