Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo in example #2

Closed
BenjaminDobler opened this issue May 28, 2015 · 2 comments
Closed

Small typo in example #2

BenjaminDobler opened this issue May 28, 2015 · 2 comments

Comments

@BenjaminDobler
Copy link

Hey,

first thanks for this awesome project!
There is a small confusion in the example package.json
It refers to assets/macos/loopline.icns but the directory structure says mount.icns

Thanks again!

@stefanjudis
Copy link
Contributor

Thanks. We'll fix that, right now. :)

Glad you like it and I hope it's running smoothly. :)

@stefanjudis
Copy link
Contributor

@BenjaminDobler

Actually the directory structure shows both icon sets.

directory structure

desktop
  |-- app                               // actual electron application
  |
  |-- assets                            // build related assets
    |-- macos                           // build assets for macos
      |-- installer.png                 //   -> referenced in packager.json
      |-- mount.icns
      |-- loopline.icns

And then the command for the electron packager refers to loopline.icns which is correct.

"build:macos": "npm run clean:macos && electron-packager ./app \"Loopline Systems\" --out=dist/macos --platform=darwin --arch=x64 --version=0.25.3 --icon=assets/macos/loopline.icns"

The mount icon is currently referenced in packager.json

  "macos" : {
    "title": "Loopline Systems",
    "background": "assets/macos/installer.png",
    "icon": "assets/macos/mount.icns",

Which also correct. I'll update the readme to make the different icons more clear and close it.

Thanks for pointing out confusing and feel free to reopen. :)

bedney added a commit to TechnicalPursuit/electron-builder that referenced this issue Aug 18, 2020
ppd added a commit to ppd/electron-builder that referenced this issue Dec 7, 2021
* make lzo the compression default in snap options

* add lzo  compression to snapcraft template

* construct compression arg from descriptor

* add tests for snap compression option
jgresham added a commit to jgresham/electron-builder that referenced this issue Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants