Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify my own location for the OSX icon file: doesn't work #197

Closed
develar opened this issue Mar 3, 2016 · 2 comments
Closed

Specify my own location for the OSX icon file: doesn't work #197

develar opened this issue Mar 3, 2016 · 2 comments

Comments

@develar
Copy link
Member

develar commented Mar 3, 2016

@jayalfredprufrock reported: I've been trying to specify my own location for the OSX icon file as detailed in the docs and it doesn't seem to be working. I know it's finding the icon because if I alter the path to something bogus it throws an error. Specifying the background image DOES work though. Oddly enough, when I place the icon.icns file and background.png file in the "build" directory and rely on the defaults, the icon loads properly but not the background. I've had to use a combination of both methods to get everything to work.

@michaelbazos
Copy link

I encountered the same problem and thought also, at first, that there was an issue with the customization of the background and the icon.

But after investigation it appears that the issue is not related to electron-builder.

It occurs if you don't unmount a DMG with the same name that was mounted before the customization.

Steps to reproduce:

  • Build a dmg with a background located at build/background.png
  • Open the dmg, then close the dialog
  • Build a new dmg with a customized background located at, say, build/osx/background.png
  • Open the dmg and notice how the background is the first one. Unless you unmount the first dmg.

develar added a commit to develar/electron-builder that referenced this issue Apr 17, 2016
@develar
Copy link
Member Author

develar commented Apr 17, 2016

Obsolete, please try 3.6.0.

@michaelbazos Please see LinusU/node-appdmg#84 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants