Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't specify an AppX icon #1940

Closed
jviotti opened this issue Aug 12, 2017 · 4 comments
Closed

Can't specify an AppX icon #1940

jviotti opened this issue Aug 12, 2017 · 4 comments

Comments

@jviotti
Copy link
Member

jviotti commented Aug 12, 2017

  • Version: 19.19.1
  • Target: appx

The AppX target doesn't seem to be able to find the icon at build/icon.ico, or by a win.icon setting.

Is there a special way to set an AppX icon? See an example AppX build, where the icon is still the default Electron logo:

no icon

@jviotti jviotti changed the title Specifying an appx icon Can't specify an AppX icon Aug 12, 2017
@jviotti
Copy link
Member Author

jviotti commented Aug 13, 2017

So looks like I can provide the following files in build/appx:

Square150x150Logo.png
Square44x44Logo.png
StoreLogo.png
Wide310x150Logo.png

I haven't seen this documented anywhere (I had to look at the code), so I might send a documentation PR soon.

@develar
Copy link
Member

develar commented Aug 13, 2017

@jviotti
Copy link
Member Author

jviotti commented Aug 17, 2017

Maybe I'm missing something, but how is that thread related to AppX packages?

develar added a commit to develar/electron-builder that referenced this issue Aug 17, 2017
@develar
Copy link
Member

develar commented Aug 17, 2017

@jviotti Sorry, link fixed, docs added — https://github.com/electron-userland/electron-builder/wiki/Icons#appx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants