Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases file for Windows not uploaded to Github #190

Closed
mcaoun opened this issue Mar 1, 2016 · 8 comments · May be fixed by qcif/data-curator#563
Closed

Releases file for Windows not uploaded to Github #190

mcaoun opened this issue Mar 1, 2016 · 8 comments · May be fixed by qcif/data-curator#563
Assignees

Comments

@mcaoun
Copy link

mcaoun commented Mar 1, 2016

I think the RELEASES file is needed on the nuts server and for windows updates, but it doesn't seem to get uploaded to Github.
(See https://github.com/GitbookIO/nuts/blob/master/docs/update-windows.md)

Looking at the code it seems to be the intended behavior given that disaptchArtifactCreated is called only for the Setup.exe and the nuget package.
https://github.com/loopline-systems/electron-builder/blob/master/src/winPackager.ts#L138

Why is that? Shouldn't the Releases file be included as well.

@develar
Copy link
Member

develar commented Mar 1, 2016

Why is that?

Not implemented due to GitbookIO/nuts#32.

@mcaoun
Copy link
Author

mcaoun commented Mar 1, 2016

Should I disable 32 bits releases - would that help?
Do I need then to manually upload the Releases files?
Should I wait for #185?

@develar
Copy link
Member

develar commented Mar 1, 2016

I will try to fix it today.

@mcaoun
Copy link
Author

mcaoun commented Mar 1, 2016

ok, thanks!

@mcaoun
Copy link
Author

mcaoun commented Mar 3, 2016

Is there something I can do to help here?

What is the plan for the fix?

Thanks

develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
@develar
Copy link
Member

develar commented Mar 3, 2016

Fixed. v2.8.5 will be published in several hours.

We upload RELEASES for x64 and RELEASES-ia32 for ia-32. Nuts issue should be fixed anyway to use ia32. Currently, you can use x64.

Please note — you should specify remoteReleases to " If given, these will be downloaded to create delta updates". I haven't tried it yet, so, cannot five details instruction.

@develar
Copy link
Member

develar commented May 13, 2016

@mcaoun Does RELEASES-ia32 solution works for you? Or I can revert this fix because of #359 (comment) ?

@mcaoun
Copy link
Author

mcaoun commented May 13, 2016

I have been building for 64-bit only since the lack of support on nuts server did not help me move further with the support for both releases versions and 32-bit is not very common for our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants