-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Squirrel.Windows to 1.7.8 #1762
Comments
Not easy to update because LZMA is introduced and we need to verify some things. |
I understand, just let me know if I can do anything. |
For now I decided to wait when LZMA compression will be finalised and proven to work (was 4 releases with bug fixes after initial release). It is quite stable now, so, will be done when I will have time to do it (and right now my home iMac is broken and my old iMac is not able to run Windows). |
There's a new release with bugfixes: https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.7.7 |
@develar what donation would be needed to get this done? willing to contribute if we could get this done soon |
Ha-ha-ha.... electron-builder PR was rejected and it was a reason of our fork... but now Squirrel.Window also uses some solution to speedup releasify — 7z. It means that difference between our fork and original will be reduced. Of course, quality of original Squirrel.Windows is not good (7z is used instead of 7za and no 32bit version of 7z), so, in any case for now we cannot use original (also, 2) code sign delegation 3) zero splash delay). I started work on updating Squirrel. I will try to send our changes to upstream again. |
Info for developers: SW now doesn't support 0-level nupkg compressed files. It means that we are forced to use level |
Unfortunately, SW still uses nuget under the hood. |
Squirrel.Windows updated to 1.7.8 in the 19.43.0.
Problem is that "complexity" of update is a result of our fork. So, it is our issue that we use it. But we have no choice because electron-builder quality level doesn't allow us to use original Squirrel.Windows build tool (it is a reason why NSIS is recommended and default target for Windows). So, updated, sorry for delay :) |
Note for Docker users — maybe you will be forced to set additional env |
thanks @develar |
There's a new version out for Squirrel.Windows which fixes several bugs in the installer/updater.
https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.7.6
The text was updated successfully, but these errors were encountered: