-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: No notification in case an error occurs during update signature verification #1680
Comments
…ure verification Closes electron-userland#1680
@develar we face a case where a user uses Windows 7 Enterprise with SP1. Of course we can tell the user to install the latest powershell, but do you think it's possible to enhance the code so that it performs a check on whether this command is supported or not? |
@MariaDima I think, for users of so old OS, we can simply disable this check and do not worry. Could you please prepare PR if agree? |
I think that our customers won't like it from security perspective. Thanks! |
Just to be sure, you suggest disabling the verification check completely, right? |
If you user decided to use unsecured and not maintained ( End of mainstream support — January 13, 2015 ) windows versions — yes. |
In case of an error during the execution of the command "Get-AuthenticodeSignature '${tempUpdateFile}' | ConvertTo-Json -Compress", no error is thrown to the upper layers.
An error could occur (for example) if either the command "Get-AuthenticodeSignature" or "ConvertTo-Json" cannot be executed.
The text was updated successfully, but these errors were encountered: