Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: No notification in case an error occurs during update signature verification #1680

Closed
MariaDima opened this issue Jun 16, 2017 · 5 comments · May be fixed by qcif/data-curator#563
Closed

Comments

@MariaDima
Copy link
Contributor

  • Version: 19.3.0
  • Target: Windows

In case of an error during the execution of the command "Get-AuthenticodeSignature '${tempUpdateFile}' | ConvertTo-Json -Compress", no error is thrown to the upper layers.

An error could occur (for example) if either the command "Get-AuthenticodeSignature" or "ConvertTo-Json" cannot be executed.

@MariaDima
Copy link
Contributor Author

MariaDima commented Jun 16, 2017

@develar we face a case where a user uses Windows 7 Enterprise with SP1.
The installed powershell version is 2.
The "ConvertTo-Json" command is supported by powershell v3 and higher.

Of course we can tell the user to install the latest powershell, but do you think it's possible to enhance the code so that it performs a check on whether this command is supported or not?
If it's supported the code with be executed as it is.
If not we drawback to a simpler execution (without much printing, or by extracting some basic info using the Get-AuthenticodeSignature).
[That's for the cases there is no problem with the execution of Get-AuthenticodeSignature]

@develar
Copy link
Member

develar commented Jun 16, 2017

@MariaDima I think, for users of so old OS, we can simply disable this check and do not worry. Could you please prepare PR if agree?

@MariaDima
Copy link
Contributor Author

I think that our customers won't like it from security perspective.
To be honest, I would prefer to guide them for upgrading powershell, rather than bypass the verification.
Let me check and if needed I'll prepare a PR.

Thanks!

@MariaDima
Copy link
Contributor Author

Just to be sure, you suggest disabling the verification check completely, right?

@develar
Copy link
Member

develar commented Jun 16, 2017

If you user decided to use unsecured and not maintained ( End of mainstream support — January 13, 2015 ) windows versions — yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants