Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pack "elevate.exe" when not needed #1620

Closed
MariaDima opened this issue Jun 5, 2017 · 3 comments · May be fixed by qcif/data-curator#563
Closed

Do not pack "elevate.exe" when not needed #1620

MariaDima opened this issue Jun 5, 2017 · 3 comments · May be fixed by qcif/data-curator#563

Comments

@MariaDima
Copy link
Contributor

  • Version: 18.5.0 (behavior changed in 13.6.0)
  • Target: Windows

When an electron application is installed in a user-controlled location, then elevation functionality seems to not be needed.

Since there is an option to allow or not elevation (allowElevation), is it possible to use it in order to not pack at all the "elevate" executable?

@develar
Copy link
Member

develar commented Jun 5, 2017

Problem — one day you decided to switch to another type of installer. For updater newly downloaded installer should be black box. And we should be able to elevate if need.

@MariaDima
Copy link
Contributor Author

You are right.

Could the updater do a cleanup before termination?

The reason I'm asking:
Security scans and IT don't like the existence of the elevate executable, so I'm trying to see if we could make it optional for the people that consider it a risk.
Otherwise, users would have to take care of this as part of their application.

@develar
Copy link
Member

develar commented Jun 6, 2017

Security scans and IT don't like the existence of the elevate executable

We should sign it, will it be enough?

I'm trying to see if we could make it optional for the people that consider it a risk.

I suggest to introduce new option for that (in the nsis NsisOptions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants