Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one file in asar archive got corrupted #1400

Closed
kutu opened this issue Mar 23, 2017 · 5 comments · May be fixed by qcif/data-curator#563
Closed

one file in asar archive got corrupted #1400

kutu opened this issue Mar 23, 2017 · 5 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@kutu
Copy link
Contributor

kutu commented Mar 23, 2017

  • Version:
    16.0.0+
  • Target:
    squirrel-windows

one of my html file got corrupted after updating to latest 16.2.0 version
downgrading versions one by one, i found that 15.6.3 works as expected

everytime i pack or build, corrupted file was always the same

then i tried to make a copy of this file in the same directory, and then this new file got corrupted everytime

so i guess, that one file is always last in app.asar file, and electron-builder do something with that file after pack it with asar util

corrupted file, got always the same size as original file, but data inside was rather 00 00 or some random bytes

@develar
Copy link
Member

develar commented Mar 23, 2017

Is it possible to provide sample project to reproduce (and filename?)

@HitomiTenshi
Copy link

HitomiTenshi commented Mar 23, 2017

  • Version: 16.0.0+
  • Target: NSIS

Same here! Ever since 16.0.0 my logo.svg file inside my assets folder gets corrupted (or lost? electron displays it as missing, although in the dev tool source list the file can be seen)

I tested every version since 16.0.0, happens with all of them. 15.6.3 works as expected.

Only happens when asar is being used. If I set asar to false, the svg image displays correctly.

I sadly can't offer a sample project at the moment.

@develar
Copy link
Member

develar commented Mar 23, 2017

Hmm.... We do check for corrupted files in our test suite, but only for main and package files. It seems I should improve out tests to check ALL files.

@kutu
Copy link
Contributor Author

kutu commented Mar 23, 2017

test_corruption.zip

npm run pack
cd dist/win-unpacked/resources
asar e app.asar app

check sidebar1.html

@develar develar added the bug label Mar 23, 2017
develar added a commit to develar/electron-builder that referenced this issue Mar 23, 2017
@develar
Copy link
Member

develar commented Mar 23, 2017

@kutu Thanks a lot. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants