Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing the sha1 of a certificate in Windows codesign #1297

Closed
ccnokes opened this issue Feb 23, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Closed

Support passing the sha1 of a certificate in Windows codesign #1297

ccnokes opened this issue Feb 23, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Assignees

Comments

@ccnokes
Copy link

ccnokes commented Feb 23, 2017

  • Version: 13.9.0
  • Target: Windows, squirrel

Currently, if you want to select a particular certificate to sign a Windows build with, you can use the certificateSubjectName parameter or CSC_LINK. In my organization, the build machine has the certificate stored in the certificate store and is not accessible via the filesystem. The preferred method of selecting a certificate to sign with is via the /sha1 parameter passed to the signtool (documented here: https://msdn.microsoft.com/en-us/library/8s9b9yaz(v=vs.110).aspx). Signing with /n SubjectName is less precise because subject names don't have to be unique and you may have 2 certs with the same name. My organization does for various reasons. Hence, signing with the /sha1 parameter is preferred and used to be supported via the signWithParams option, which was later removed.

I might look at PRing this sometime but thought I'd create an issue here first 😸

@develar develar changed the title Feature request: Support passing the sha1 of a certificate in Windows codesign Support passing the sha1 of a certificate in Windows codesign Feb 24, 2017
@develar develar self-assigned this Feb 24, 2017
develar added a commit to develar/electron-builder that referenced this issue Feb 24, 2017
@ccnokes
Copy link
Author

ccnokes commented Feb 24, 2017

@develar thanks! You beat me to it. I was working on it last night: ccnokes@c2029a1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants