Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only first artifact is uploaded to GitHub #1133

Closed
bayleedev opened this issue Jan 17, 2017 · 15 comments · May be fixed by qcif/data-curator#563
Closed

Only first artifact is uploaded to GitHub #1133

bayleedev opened this issue Jan 17, 2017 · 15 comments · May be fixed by qcif/data-curator#563

Comments

@bayleedev
Copy link

  • Version: 11.2.3
  • Target: Linux (dmg), mac and windows
  • Command: build --x64 --publish onTagOrDraft

Setup

I am having Travis CI run mac and linux, and appveyor run windows.

Expected Behavior

When I push a tag it to create a release on github and upload the 3 artifacts.

Actual Behavior

The first CI job that finishes uploads the artifact, and the others do not.

Additional Information

I have deleted the release on github multiple times to run each job individually, the first one to finish is always the one to upload the artifact, while the others do not upload. I am working on this branch trying to push a dummy version 0.3.2-beb to make sure it works before merging.

@bayleedev bayleedev changed the title Only Only first artifact is uploaded to GitHub Jan 17, 2017
@develar
Copy link
Member

develar commented Jan 17, 2017

Does it work for 11.4.4?

@develar
Copy link
Member

develar commented Jan 18, 2017

You set draft to false, but artifacts are not published for non-draft github release. So, first CI creates release and upload, but second cannot. To be fixed.

@bayleedev
Copy link
Author

Is there a timeline for this being fixed, or is there a workaround I can do until then?

@develar
Copy link
Member

develar commented Jan 19, 2017

@blainesch Right now I review change before push :)

@bayleedev
Copy link
Author

Super quick, thanks :D

@develar
Copy link
Member

develar commented Jan 19, 2017

It will be released as 11.5.0 in 30 minutes (if CI will be green ;)).

@bayleedev
Copy link
Author

]: It's still not uploading them all

https://travis-ci.org/tinytacoteam/zazu/builds/193498058
https://ci.appveyor.com/project/blainesch/zazu

You can see in the output it's installing 11.5.0

develar added a commit to develar/electron-builder that referenced this issue Jan 24, 2017
@develar
Copy link
Member

develar commented Jan 24, 2017

@blainesch Please try 11.5.2 and set env DEBUG=electron-builder

develar added a commit to develar/electron-builder that referenced this issue Jan 25, 2017
@develar develar reopened this Jan 27, 2017
@develar
Copy link
Member

develar commented Feb 2, 2017

@blainesch Why do you use draft: false? It leads to issue: one CI publishes release, but another CI is still not yet upload artifacts. Why don't you want to follow default workflow and publish release (edit release -> publish) manually? https://electron-builder.slack.com/archives/general/p1485961449000202

@bayleedev
Copy link
Author

@develar mostly preference. If it would work without the draft I'll turn it off.

@develar
Copy link
Member

develar commented Feb 2, 2017

@blainesch Please to remove draft option.

@develar
Copy link
Member

develar commented Feb 8, 2017

@blainesch Does it work for you?

@bayleedev
Copy link
Author

Yes removing the flag fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants