Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build config from package.json #1109

Closed
jakubzitny opened this issue Jan 12, 2017 · 9 comments · May be fixed by qcif/data-curator#563
Closed

Separate build config from package.json #1109

jakubzitny opened this issue Jan 12, 2017 · 9 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@jakubzitny
Copy link

jakubzitny commented Jan 12, 2017

  • Version: latest
  • Target: mac, win, linux

I think it might be nice thing to consider to separate the build from package.json to a separate file, e.g. build.json. It could be optional in a way that either build key in package.json or build.json would apply if present, similar to what ava has. What do you think?

It could make large package.jsons more readable. If we already have 250 lines in package.json another 50-100 lines for build config make it quite unreadable.

I did a quick search in issues and couldn't find anything related, so sorry if this has already been discussed here.

@develar
Copy link
Member

develar commented Jan 13, 2017

#971 (comment)

What do you think about electron-builder.yml?

@jakubzitny
Copy link
Author

Yeah that would be great 👍

Haven't really seen the YAML usage in JS world a lot, but it has its advantages. I would support json as well though. People will be able to migrate between their "build" part in package.json and the new extra file as they wish.

develar added a commit to develar/electron-builder that referenced this issue Jan 15, 2017
develar added a commit to develar/electron-builder that referenced this issue Jan 15, 2017
@develar
Copy link
Member

develar commented Jan 15, 2017

You can write JSON in the yaml, you don't need to learn new syntax.

@jakubzitny
Copy link
Author

Did not realize that, thanks. :)

@develar
Copy link
Member

develar commented Jan 16, 2017

I am going to add support for json and json5 to be sure that users are happy :)

@jakubzitny
Copy link
Author

jakubzitny commented Jan 19, 2017

Hi @develar, when is this going to be available in npm?
I have 11.4.4 and I am getting Unknown argument: config.

@develar
Copy link
Member

develar commented Jan 19, 2017

Currently no cli arg, just create file electron-builder.yml in the project root.

@jakubzitny
Copy link
Author

Allright, that does work.

@jakubzitny
Copy link
Author

Hi @develar, are there any plans to add --config parameter so the config YAML can have different locations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants