Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsis to use productName rather than name for install path #1100

Closed
timfish opened this issue Jan 9, 2017 · 5 comments · May be fixed by qcif/data-curator#563
Closed

nsis to use productName rather than name for install path #1100

timfish opened this issue Jan 9, 2017 · 5 comments · May be fixed by qcif/data-curator#563

Comments

@timfish
Copy link
Contributor

timfish commented Jan 9, 2017

pacakge.json

{ 
  "name": "myapp",
  "productName": "My App",
  "author": "My Company",

...
    "nsis": {
      "oneClick": false,
      "allowToChangeInstallationDirectory": true,
      "menuCategory": true,
      "runAfterFinish": false
    },

On selecting per machine install, the default path is:

C:\Program Files (x86)\My Company\myapp

Whereas I was hoping for:

C:\Program Files (x86)\My Company\My App

I simply want to do this to match the existing installers of My Company.

Obviously productName can contain characters which are not valid for use in file paths, so this functionality as a default might not be a good idea.

@develar
Copy link
Member

develar commented Jan 11, 2017

Option will be added this week. It was decided to use name because productName is not safe and suitable for number of users..

@timfish
Copy link
Contributor Author

timfish commented Jan 11, 2017

It was decided to use name because productName is not safe and suitable for number of users

Thanks. Guessed as much!

@mastergberry
Copy link
Contributor

Definitely wanted :) Thanks

@mastergberry
Copy link
Contributor

@develar any quick update on this? A much desired feature before we push out our installer to users in the next week or so.

develar added a commit to develar/electron-builder that referenced this issue Jan 26, 2017
…hes /^[-_0-9a-zA-Z ]+$/

BREAKING CHANGE: installation path change

Close electron-userland#1100
develar added a commit to develar/electron-builder that referenced this issue Jan 26, 2017
…hes /^[-_0-9a-zA-Z ]+$/

BREAKING CHANGE: installation path change

Close electron-userland#1100, electron-userland#767
@develar
Copy link
Member

develar commented Jan 26, 2017

I don't want to introduce yet another option. If product name matches /^[-_0-9a-zA-Z ]+$/, it will be used instead of safe name (applicable only for perMachine or boring installer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants