Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update download uses lot of cpu, and may lost connection, and error not catchable #1010

Closed
zh99998 opened this issue Dec 15, 2016 · 3 comments · May be fixed by qcif/data-curator#563
Closed
Labels

Comments

@zh99998
Copy link

zh99998 commented Dec 15, 2016

  • Version: 10.8.1
  • Target: win32
  1. when downloading updates, it uses lots of CPU.
    Imgur

(when not in update, it only use < 10%).

  1. update may lost connection and get a incomplete package, then throw SHA2 checksum error. my service is over https, and a complete package is always correct. but they often download a incomplete one. there is apart of my nginx log:
    Imgur

my app total length is 35925496, but he failed 2 times before got a complete one.
I'm sure he is not close my app manually, he's waiting for update, and got a sha2 checksum error.

his network to my server works well, when using wget or browser, download will always complete.

  1. the sha2 checksum error is not catchable.
    I've listened autoUpdater.on("error") event, but still throws a error window.

Imgur

@develar
Copy link
Member

develar commented Dec 19, 2016

We will soon use chrome API to download instead of node. Please see #1024

@ghost
Copy link

ghost commented Dec 21, 2016

I have the same issue. I think it's because sha2 mismatch throws an exception from within a promise here. Wouldn't it make more sense to use the error callback?

@develar
Copy link
Member

develar commented Dec 21, 2016

Fixed in electron-auto-updater 0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants