fix(packager): return success status from doSign function calls (#7431)

electron-userland · Mar 4, 2023 · eb842f7 · eb842f7
1 parent 22ee62a
commit eb842f7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/real-poets-compare.md b/.changeset/real-poets-compare.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix packager: return success status from doSign function calls
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -376,7 +376,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
   }
 
   //noinspection JSMethodCanBeStatic
-  protected async doSign(opts: SignOptions): Promise<any> {
+  protected doSign(opts: SignOptions): Promise<any> {
     return signAsync(opts)
   }
 
@@ -457,7 +457,6 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
 
     const appFileName = `${this.appInfo.productFilename}.app`
     await readDirectoryAndSign(packContext.appOutDir, await readdir(packContext.appOutDir), file => file === appFileName)
-
     if (!isAsar) {
       return true
     }

diff --git a/packages/app-builder-lib/src/winPackager.ts b/packages/app-builder-lib/src/winPackager.ts
@@ -210,7 +210,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
     const cscInfo = await this.cscInfo.value
     if (cscInfo == null) {
       if (this.platformSpecificBuildOptions.sign != null) {
-        await sign(signOptions, this)
+        return await sign(signOptions, this)
       } else if (this.forceCodeSigning) {
         throw new InvalidConfigurationError(
           `App is not signed and "forceCodeSigning" is set to true, please ensure that code signing configuration is correct, please see https://electron.build/code-signing`