fix: skip rcedit for .msi installer

Close #677
electron-userland · Aug 17, 2016 · d40e0b5 · d40e0b5
1 parent 903148b
commit d40e0b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.idea/dictionaries/develar.xml b/.idea/dictionaries/develar.xml
diff --git a/src/targets/squirrelPack.ts b/src/targets/squirrelPack.ts
@@ -99,7 +99,8 @@ export async function buildInstaller(options: SquirrelOptions, outputDirectory:
   if (options.msi && process.platform === "win32") {
     const outFile = setupExe.replace(".exe", ".msi")
     await msi(options, nupkgPath, setupPath, outputDirectory, outFile)
-    await packager.signAndEditResources(path.join(outputDirectory, outFile))
+    // rcedit can only edit .exe resources
+    await packager.sign(path.join(outputDirectory, outFile))
   }
 }