fix: NSIS Installer hangs when being run silently

Closes #616
electron-userland · Jul 31, 2016 · d0a4f90 · d0a4f90
1 parent 3418239
commit d0a4f90
Showing 1 changed file with 19 additions and 15 deletions.
diff --git a/templates/nsis/installer.nsi b/templates/nsis/installer.nsi
@@ -58,15 +58,17 @@ Function un.onInit
 FunctionEnd
 
 Section "install"
-  SetDetailsPrint none
-
-  !ifdef ONE_CLICK
-    !ifdef HEADER_ICO
-      SpiderBanner::Show /MODERN /ICON "$PLUGINSDIR\installerHeaderico.ico"
-    !else
-      SpiderBanner::Show /MODERN
-   !endif
-  !endif
+  ${IfNot} ${Silent}
+    SetDetailsPrint none
+
+    !ifdef ONE_CLICK
+      !ifdef HEADER_ICO
+        SpiderBanner::Show /MODERN /ICON "$PLUGINSDIR\installerHeaderico.ico"
+      !else
+        SpiderBanner::Show /MODERN
+     !endif
+    !endif
+  ${EndIf}
 
   !insertmacro CHECK_APP_RUNNING "install"
 
@@ -104,13 +106,15 @@ Section "install"
     !insertmacro customInstall
   !endif
 
-  !ifdef ONE_CLICK
-    # otherwise app window will be in backround
-    HideWindow
-    !ifdef RUN_AFTER_FINISH
-      Call StartApp
+  ${IfNot} ${Silent}
+    !ifdef ONE_CLICK
+      # otherwise app window will be in backround
+      HideWindow
+      !ifdef RUN_AFTER_FINISH
+        Call StartApp
+      !endif
     !endif
-  !endif
+  ${EndIf}
 SectionEnd
 
 Section "un.install"