Skip to content

Commit

Permalink
Fix: handle dependencies with package 'link' fields (#2690)
Browse files Browse the repository at this point in the history
fix: when parsing dependencies, overwrite any 'link' property already set in package.json

Some projects, like Mozilla Aframe, set a 'link' property at the root of their package.json file.
This causes problems for our packageDependencies job, which extends that object and adds 'link'
to signify the dependency dir is a symlink. Overwrite property by default.

Closes #2685
  • Loading branch information
jbreckmckye authored and develar committed Mar 14, 2018
1 parent e5d97bc commit cca3168
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/electron-builder-lib/src/util/packageDependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,9 @@ class Collector {
}
else {
metadata.parent = parent

// overwrite if already set by project package.json
metadata.link = undefined
}

metadata.path = rawDir
Expand Down

0 comments on commit cca3168

Please sign in to comment.