fix(deployment): disable automatic detection for S3

Close #1334
electron-userland · Mar 6, 2017 · c4744af · c4744af
1 parent 3ee8a59
commit c4744af
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/docs/Publishing Artifacts.md b/docs/Publishing Artifacts.md
@@ -80,7 +80,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b
 
 If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`.
 If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`.
-If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`.
 
 Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS).
 

diff --git a/packages/electron-builder-http/src/publishOptions.ts b/packages/electron-builder-http/src/publishOptions.ts
@@ -7,7 +7,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b
 
 If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`.
 If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`.
-If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`.
 
 Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS).
 

diff --git a/packages/electron-builder/src/publish/PublishManager.ts b/packages/electron-builder/src/publish/PublishManager.ts
@@ -368,9 +368,6 @@ export async function getPublishConfigs(packager: PlatformPackager<any>, targetS
     else if (!isEmptyOrSpaces(process.env.BT_TOKEN)) {
       serviceName = "bintray"
     }
-    else if (!isEmptyOrSpaces(process.env.AWS_ACCESS_KEY_ID) && !isEmptyOrSpaces(process.env.AWS_SECRET_ACCESS_KEY)) {
-      serviceName = "s3"
-    }
 
     if (serviceName != null) {
       debug(`Detect ${serviceName} as publish provider`)