fix: dereference copied app files only for windows targets

In any case we don't reference if asar
electron-userland · Jul 1, 2016 · bf2aafb · bf2aafb
1 parent 11e6d0f
commit bf2aafb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/platformPackager.ts b/src/platformPackager.ts
@@ -197,7 +197,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
 
       const filter = createFilter(this.info.appDir, this.getParsedPatterns(patterns, arch), ignoreFiles, rawFilter)
       const promise = asarOptions == null ?
-        copyFiltered(this.info.appDir, appPath, filter, true)
+        copyFiltered(this.info.appDir, appPath, filter, this.platform === Platform.WINDOWS)
         : createAsarArchive(this.info.appDir, resourcesPath, asarOptions, filter)
 
       const promises = [promise, unlinkIfExists(path.join(resourcesPath, "default_app.asar")), unlinkIfExists(path.join(appOutDir, "version"))]
@@ -301,7 +301,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
   private async doCopyExtraFiles(isResources: boolean, appOutDir: string, arch: Arch, customBuildOptions: DC): Promise<any> {
     const base = isResources ? this.getResourcesDir(appOutDir) : this.platform === Platform.MAC ? path.join(appOutDir, `${this.appInfo.productFilename}.app`, "Contents") : appOutDir
     const patterns = this.getFilePatterns(isResources ? "extraResources" : "extraFiles", customBuildOptions)
-    return patterns == null || patterns.length === 0 ? null : copyFiltered(this.projectDir, base, createFilter(this.projectDir, this.getParsedPatterns(patterns, arch)))
+    return patterns == null || patterns.length === 0 ? null : copyFiltered(this.projectDir, base, createFilter(this.projectDir, this.getParsedPatterns(patterns, arch)), this.platform === Platform.WINDOWS)
   }
 
   private getParsedPatterns(patterns: Array<string>, arch: Arch): Array<Minimatch> {

diff --git a/src/util/filter.ts b/src/util/filter.ts
@@ -7,7 +7,7 @@ import * as path from "path"
 const __awaiter = require("./awaiter")
 
 // we use relative path to avoid canonical path issue - e.g. /tmp vs /private/tmp
-export function copyFiltered(src: string, destination: string, filter: (file: string) => boolean, dereference: boolean = false): Promise<any> {
+export function copyFiltered(src: string, destination: string, filter: (file: string) => boolean, dereference: boolean): Promise<any> {
   return copy(src, destination, {
     dereference: dereference,
     filter: filter