feat(publisher): Check that tag name starts with "v" #340

electron-userland · Jun 26, 2016 · bb71621 · bb71621
1 parent 65650ea
commit bb71621
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 4 deletions.
diff --git a/src/gitHubPublisher.ts b/src/gitHubPublisher.ts
@@ -40,15 +40,19 @@ export class GitHubPublisher implements Publisher {
     return this._releasePromise
   }
 
-  constructor(private owner: string, private repo: string, version: string, private options: PublishOptions, private isPublishOptionGuessed: boolean = false) {
+  constructor(private owner: string, private repo: string, private version: string, private options: PublishOptions, private isPublishOptionGuessed: boolean = false) {
     if (isEmptyOrSpaces(options.githubToken)) {
       throw new Error("GitHub Personal Access Token is not specified")
     }
 
     this.token = options.githubToken!
-    this.policy = options.publish!
+    this.policy = options.publish || "always"
 
-    this.tag = "v" + version
+    if (version.startsWith("v")) {
+      throw new Error(`Version must not starts with "v": ${version}`)
+    }
+
+    this.tag = `v${version}`
     this._releasePromise = <BluebirdPromise<Release>>this.init()
   }
 
@@ -75,6 +79,9 @@ export class GitHubPublisher implements Publisher {
         }
         return null
       }
+      else if (release.tag_name === this.version) {
+        throw new Error(`Tag name must starts with "v": ${release.tag_name}`)
+      }
     }
 
     if (createReleaseIfNotExists) {

diff --git a/src/targets/nsis.ts b/src/targets/nsis.ts
@@ -84,7 +84,7 @@ export default class NsisTarget extends Target {
       defines.MUI_HEADERIMAGE_BITMAP = installerHeader
     }
 
-    const headerIcon = oneClick ? await this.getResource(this.options.installerHeader, "headerIcon.ico") : null
+    const headerIcon = oneClick ? await this.getResource(this.options.headerIcon, "headerIcon.ico") : null
     if (headerIcon != null) {
       defines.HEADER_ICO = headerIcon
     }

diff --git a/test/src/ArtifactPublisherTest.ts b/test/src/ArtifactPublisherTest.ts
@@ -79,6 +79,28 @@ testAndIgnoreApiRate("prerelease", async () => {
   }
 })
 
+testAndIgnoreApiRate("incorrect tag name", async () => {
+  const publisher = new GitHubPublisher("actperepo", "ecb2", "5.0", {
+    githubToken: token,
+    draft: false,
+    prerelease: true,
+    publish: "onTagOrDraft",
+  })
+  try {
+    await publisher.releasePromise
+    //noinspection ExceptionCaughtLocallyJS
+    throw new Error("No expected error")
+  }
+  catch (e) {
+    if (e.message !== 'Tag name must starts with "v": 5.0') {
+      throw e
+    }
+  }
+  finally {
+    await publisher.deleteRelease()
+  }
+})
+
 testAndIgnoreApiRate("GitHub upload org", async () => {
   //noinspection SpellCheckingInspection
   const publisher = new GitHubPublisher("builder-gh-test", "darpa", versionNumber(), {