fix: artifactName for portable

Close #1340
electron-userland · Mar 13, 2017 · 8f6247a · 8f6247a
1 parent 2e7b668
commit 8f6247a
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/packages/electron-builder/src/targets/nsis.ts b/packages/electron-builder/src/targets/nsis.ts
@@ -33,7 +33,7 @@ export default class NsisTarget extends Target {
 
     let options = this.packager.config.nsis || Object.create(null)
     if (targetName !== "nsis") {
-      options = Object.assign(options, (<any>this.packager.config)[targetName === "nsis-web" ? "nsisWeb" : ""])
+      options = Object.assign(options, (<any>this.packager.config)[targetName === "nsis-web" ? "nsisWeb" : targetName])
     }
     this.options = options
 

diff --git a/test/out/windows/__snapshots__/installerTest.js.snap b/test/out/windows/__snapshots__/installerTest.js.snap
@@ -49,6 +49,17 @@ Object {
 }
 `;
 
+exports[`portable - artifactName 1`] = `
+Object {
+  "win": Array [
+    Object {
+      "file": "Test App ßWPortable.1.1.0.exe",
+      "safeArtifactName": "TestApp-1.1.0.exe",
+    },
+  ],
+}
+`;
+
 exports[`portable 1`] = `
 Object {
   "win": Array [

diff --git a/test/src/windows/installerTest.ts b/test/src/windows/installerTest.ts
@@ -121,4 +121,16 @@ test.ifNotCiMac("portable", app({
     nsis: {
     }
   }
+}))
+
+test.ifAll.ifNotCiMac("portable - artifactName", app({
+  targets: Platform.WINDOWS.createTarget(["portable"]),
+  config: {
+    "nsis": {
+      "artifactName": "${productName}Installer.${version}.${ext}"
+    },
+    "portable": {
+      "artifactName": "${productName}Portable.${version}.${ext}"
+    }
+  }
 }))