Skip to content

Commit

Permalink
fix: add warning to macCodeSign when skipping code signing on M1 macO…
Browse files Browse the repository at this point in the history
…S device (#6522)

On M1 macOS laptop, If you skip code signing, it will cause your bundled macOS app not to work as expected. e.g.
- The macOS localization description will not visible in the request permission action.
- The macOS request permission grant notify will trigger multiple times
  • Loading branch information
Matrixbirds authored Dec 31, 2021
1 parent 344bb23 commit 8730027
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/codeSign/macCodeSign.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export async function reportError(
if (qualifier == null) {
logFields.reason = ""
if (isAutoDiscoveryCodeSignIdentity()) {
logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate`}`
logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible`}`
}
logFields.reason += ", see https://electron.build/code-signing"
if (!isAutoDiscoveryCodeSignIdentity()) {
Expand Down

0 comments on commit 8730027

Please sign in to comment.