feat: warn when skipping mac app signing due to unsupported platform

Closes #849
electron-userland · Oct 25, 2016 · 7c810a7 · 7c810a7
1 parent f69d202
commit 7c810a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/Multi Platform Build.md b/docs/Multi Platform Build.md
@@ -3,7 +3,7 @@ Don't expect that you can build app for all platforms on one platform.
 * If your app has native dependencies, it can be compiled only on the target platform.
 [prebuild](https://www.npmjs.com/package/prebuild) is a solution, but most node modules [don't provide](https://github.com/atom/node-keytar/issues/27) prebuilt binaries.
 
-* OS Code Signing works only on MacOS. [Cannot be fixed](http://stackoverflow.com/a/12156576).
+* macOS Code Signing works only on macOS. [Cannot be fixed](http://stackoverflow.com/a/12156576).
 
 Don't think that mentioned issues are major, you should use build servers — e.g. [AppVeyor](http://www.appveyor.com/) to build Windows app and [Travis](https://travis-ci.org) to build MacOS/Linux apps.
 

diff --git a/src/macPackager.ts b/src/macPackager.ts
@@ -94,6 +94,7 @@ export default class MacPackager extends PlatformPackager<MacOptions> {
 
   private async sign(appOutDir: string, masOptions: MasBuildOptions | null): Promise<void> {
     if (process.platform !== "darwin") {
+      warn("macOS application code signing is not supported on this platform, skipping.")
       return
     }
-Original file line number
+Diff line change
@@ Expand Up @@
       private async sign(appOutDir: string, masOptions: MasBuildOptions | null): Promise<void> {
         if (process.platform !== "darwin") {
+          warn("macOS application code signing is not supported on this platform, skipping.")
           return
         }
@@ Expand Down @@