feat: ignore .gitignore,.gitattributes,.editorconfig,.idea by default

Also appveyor.yml,.travis.yml,circle.yml
electron-userland · Sep 19, 2016 · 70abaa3 · 70abaa3
1 parent 1ad417f
commit 70abaa3
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 17 deletions.
diff --git a/docker/4/Dockerfile b/docker/4/Dockerfile
@@ -1,6 +1,6 @@
 FROM electronuserland/electron-builder:base
 
-ENV NODE_VERSION 4.4.7
+ENV NODE_VERSION 4.5.0
 
 # https://github.com/npm/npm/issues/4531
 RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \

diff --git a/docker/6/Dockerfile b/docker/6/Dockerfile
@@ -1,6 +1,6 @@
 FROM electronuserland/electron-builder:base
 
-ENV NODE_VERSION 6.3.1
+ENV NODE_VERSION 6.6.0
 
 # https://github.com/npm/npm/issues/4531
 RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \

diff --git a/docker/npm/build.sh b/docker/npm/build.sh
diff --git a/src/platformPackager.ts b/src/platformPackager.ts
@@ -194,7 +194,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
       defaultMatcher.addPattern("!**/node_modules/*/{README.md,README,readme.md,readme,test}")
       defaultMatcher.addPattern("!**/node_modules/.bin")
       defaultMatcher.addPattern("!**/*.{o,hprof,orig,pyc,pyo,rbc}")
-      defaultMatcher.addPattern("!**/{.DS_Store,.git,.hg,.svn,CVS,RCS,SCCS,__pycache__,thumbs.db}")
+      defaultMatcher.addPattern("!**/{.DS_Store,.git,.hg,.svn,CVS,RCS,SCCS,__pycache__,thumbs.db,.gitignore,.gitattributes,.editorconfig,.idea,appveyor.yml,.travis.yml,circle.yml}")
 
       let rawFilter: any = null
       const deprecatedIgnore = (<any>this.devMetadata.build).ignore

diff --git a/src/publish/gitHubPublisher.ts b/src/publish/gitHubPublisher.ts
@@ -51,7 +51,7 @@ export class GitHubPublisher implements Publisher {
       throw new Error(`Version must not starts with "v": ${version}`)
     }
 
-    this.tag = config == null || config.vPrefixedTagName ? `v${version}` : version
+    this.tag = config != null && config.vPrefixedTagName === false ? version : `v${version}`
     this._releasePromise = this.token === "__test__" ? BluebirdPromise.resolve(<any>null) : <BluebirdPromise<Release>>this.init()
   }