Skip to content

Commit

Permalink
fix: inherit stdio for updated processes (#7393)
Browse files Browse the repository at this point in the history
  • Loading branch information
ganthern committed Jan 25, 2023
1 parent 0448896 commit 5bbc450
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/sharp-olives-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"electron-updater": patch
---

fix: inherit stdio for updated processes (#7393)
4 changes: 2 additions & 2 deletions packages/electron-updater/src/BaseUpdater.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export abstract class BaseUpdater extends AppUpdater {
protected spawnSyncLog(cmd: string, args: string[] = [], env = {}): string {
this._logger.info(`Executing: ${cmd} with args: ${args}`)
const response = spawnSync(cmd, args, {
stdio: "pipe",
stdio: "inherit",
env: { ...process.env, ...env },
encoding: "utf-8",
shell: true,
Expand All @@ -139,7 +139,7 @@ export abstract class BaseUpdater extends AppUpdater {
return new Promise<boolean>((resolve, reject) => {
try {
const p = spawn(cmd, args, {
stdio: "pipe",
stdio: "inherit",
env: { ...process.env, ...env },
detached: true,
})
Expand Down

0 comments on commit 5bbc450

Please sign in to comment.