fix: Look for the Amazon cred header to remove auth header (#5594)

electron-userland · Feb 16, 2021 · 46a8840 · 46a8840
1 parent 0ba839b
commit 46a8840
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/builder-util-runtime/src/httpExecutor.ts b/packages/builder-util-runtime/src/httpExecutor.ts
@@ -299,8 +299,9 @@ Please double check that your authentication token is correct. Due to security r
     const headers = newOptions.headers
     if (headers != null && headers.authorization != null && (headers.authorization as string).startsWith("token")) {
       const parsedNewUrl = new URL(redirectUrl)
-      if (parsedNewUrl.hostname.endsWith(".amazonaws.com")) {
-        delete headers.authorization
+      if (parsedNewUrl.hostname.endsWith(".amazonaws.com") ||
+        parsedNewUrl.searchParams.has("X-Amz-Credential")) {
+        delete headers.authorization;
       }
     }
     return newOptions
@@ -483,4 +484,4 @@ export function safeStringifyJson(data: any, skippedNames?: Set<string>) {
     }
     return value
   }, 2)
-}
+}