refactor: remove deprecated iconUrl (should be in the squirrelWindows)

electron-userland · Mar 21, 2017 · 3782e34 · 3782e34
1 parent 0b9b1fd
commit 3782e34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/packages/electron-builder-squirrel-windows/src/squirrelWindows.ts b/packages/electron-builder-squirrel-windows/src/squirrelWindows.ts
@@ -49,7 +49,7 @@ export default class SquirrelWindowsTarget extends Target {
 
   async computeEffectiveDistOptions(): Promise<SquirrelOptions> {
     const packager = this.packager
-    let iconUrl = this.options.iconUrl || packager.config.iconUrl
+    let iconUrl = this.options.iconUrl
     if (iconUrl == null) {
       const info = await packager.info.repositoryInfo
       if (info != null) {

diff --git a/packages/electron-builder/src/metadata.ts b/packages/electron-builder/src/metadata.ts
@@ -64,12 +64,7 @@ export interface Config extends PlatformSpecificBuildOptions {
    * The human-readable copyright line for the app. Defaults to `Copyright © year author`.
    */
   readonly copyright?: string | null
-
-  /**
-   * @private
-   */
-  readonly iconUrl?: string | null
-
+
   /**
    * As [name](#AppMetadata-name), but allows you to specify a product name for your executable which contains spaces and other special characters not allowed in the [name property](https://docs.npmjs.com/files/package.json#name}).
    */