Skip to content

Commit

Permalink
fix:(appx): invalid CA publisher syntax from app-builder (#3501, #4931)…
Browse files Browse the repository at this point in the history
… (#5356)

honor publisher in `package.json`, for example:
```JSON
"build": {
    "appx": {
        "publisher": "CN=\"Bob Doe\", O=\"Bob Doe\", STREET=123 Fake St., L=London, S=London, PostalCode=A1042, C=GB",
    }
}
```
  • Loading branch information
rainbean authored Nov 28, 2020
1 parent 1235c4e commit 289ea27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/targets/AppxTarget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export default class AppXTarget extends Target {
}

const certInfo = await this.packager.lazyCertInfo.value
const publisher = certInfo == null ? null : certInfo.bloodyMicrosoftSubjectDn
const publisher = this.options.publisher || (certInfo == null ? null : certInfo.bloodyMicrosoftSubjectDn)
if (publisher == null) {
throw new Error("Internal error: cannot compute subject using certificate info")
}
Expand Down

0 comments on commit 289ea27

Please sign in to comment.