Skip to content

Commit

Permalink
feat: Code signing windows app using SHA256
Browse files Browse the repository at this point in the history
Closes #386
  • Loading branch information
develar committed May 10, 2016
1 parent 633d006 commit 032ba05
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ Complete solution to build ready for distribution and "auto update" installers o
* [Build version management](#build-version-management).
* [Publishing artifacts to GitHub Releases](https://github.com/electron-userland/electron-builder/wiki/Publishing-Artifacts).

[electron-packager](https://github.com/electron-userland/electron-packager),
[appdmg](https://github.com/LinusU/node-appdmg) and
[windows-installer](https://github.com/electron/windows-installer) are used under the hood.
[electron-packager](https://github.com/electron-userland/electron-packager) and
[appdmg](https://github.com/LinusU/node-appdmg) are used under the hood.

Real project example — [onshape-desktop-shell](https://github.com/develar/onshape-desktop-shell).

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"deep-assign": "^2.0.0",
"electron-osx-sign-tf": "0.4.0-beta.0",
"electron-packager-tf": "^7.0.2-beta.0",
"electron-winstaller-fixed": "~2.4.0-beta.1",
"electron-winstaller-fixed": "~2.5.0",
"fs-extra-p": "^1.0.1",
"globby": "^4.0.0",
"hosted-git-info": "^2.1.4",
Expand Down Expand Up @@ -101,7 +101,7 @@
"json-parse-helpfulerror": "^1.0.3",
"path-sort": "^0.1.0",
"plist": "^1.2.0",
"pre-git": "^3.8.3",
"pre-git": "^3.8.4",
"semantic-release": "^4.3.5",
"should": "^8.3.1",
"ts-babel": "^0.8.6",
Expand Down
2 changes: 1 addition & 1 deletion src/winPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class WinPackager extends PlatformPackager<WinBuildOptions> {
usePackageJson: false,
noMsi: true,
extraFileSpecs: this.extraNuGetFileSources == null ? null : ("\n" + (await this.extraNuGetFileSources).join("\n")),
extraMetadataSpecs: projectUrl == null ? null : `\n<projectUrl>${projectUrl}</projectUrl>`,
extraMetadataSpecs: projectUrl == null ? null : `\n <projectUrl>${projectUrl}</projectUrl>`,
sign: {
name: this.appName,
site: projectUrl,
Expand Down

0 comments on commit 032ba05

Please sign in to comment.