Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code signing windows app using SHA256 #386

Closed
ajaysridharan opened this issue May 9, 2016 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Code signing windows app using SHA256 #386

ajaysridharan opened this issue May 9, 2016 · 2 comments · May be fixed by qcif/data-curator#563
Labels
feature windows

Comments

@ajaysridharan
Copy link

While code signing works flawlessly in AppVeyor (windows environment), the installer is signed using SHA1. Win10 requires at least SHA256 and I'm unable to find documentation to specify SHA256 for code signing. Whereas, code signing windows app in OSX environment seems to use SHA256. Am I missing something?
@develar
Copy link
Member

develar commented May 10, 2016

Confirmed, fixed, release will be today.

@develar
Copy link
Member

develar commented May 11, 2016

Release is still not production ready — yet another fix — we must use dual-code sign (sha1+sha256) to not break old Windows version. And sign must be timestamped (as OS X already does).

@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump electron-builder from 19.55.2 to 20.5.1 qcif/data-curator
2 participants
@develar @ajaysridharan