support preload.ts

[sminf]

closes #3058

[UserJHansen]

lgtm, looks like it might be able to be done better though, using more out files in the original build

[sminf]

lgtm, looks like it might be able to be done better though, using more out files in the original build

Where is the original build located? Is release/app/dist/? If so, I use .erb/dll directory intentionally to store development preload.js without affecting release build.

[amilajack]

Thanks for this PR! This has been a long awaited feature of the boilerplate. Here's a few minor comments.

[anasrar]

issue that I found is webpack keep watch preload.ts after electron close in npm start and also nice to have preload.d.ts for better type checking in react side.

src/preload.d.ts

declare global {
  interface Window {
    electron: {
      ipcRenderer: {
        myPing(): void;
        on(channel: string, func: (...args: any[]): void;
        once(channel: string, func: (...args: any[]): void;
      };
    };
  };
};

export {};

[amilajack]

@anasrar great feedback and good catch. @anniekatlin can you also incorporate @anasrar's feedback

[anasrar]

my current solution is polling check the parent PID using webpack hook

.erb/configs/webpack.config.preload.dev.ts

class CheckParentPIDProcess {
  interval: number;

  constructor(interval: number) {
    this.interval = interval;
  }

  check() {
    try {
      process.kill(parseInt(process.env.PARENT_PID), 0);
    } catch (e) {
      process.exit(0);
    }
    setTimeout(() => {
      this.check();
    }, this.interval);
  }

  apply(compiler: Compiler) {
    if (!process.env.hasOwnProperty('PARENT_PID')) {
      console.log('PARENT_PID not found on environment');
      return;
    }
    compiler.hooks.entryOption.tap('CheckPIDProcess', (context, entry) => {
      console.log(`Start check parent PID process: ${process.env.PARENT_PID}`);
      // recommend using promise instead of setTimeout
      setTimeout(() => {
        this.check();
      }, this.interval);
    });
  }
}

const configuration: webpack.Configuration = {
  // ...
  plugins: [
    // ...
    new CheckParentPIDProcess(3000),
  ]
}

and passing PARENT_PID to environment in .erb/configs/webpack.config.renderer.dev.ts before spawn npm run start:preload

process.env.PARENT_PID = process.pid.toString();

[sminf]

I rebased my fork causing this PR being closed, and then reopen this PR after pushing latest commit, now it still request changing now. Please review this, thanks. @amilajack

[amilajack]

@anniekatlin thanks for the contribution 🥳 this is been a long awaited feature!

[shyamkumaryadav]

Thanks @anniekatlin

[dddreee]

Thanks a lot!