Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle event registration and removal #66

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Handle event registration and removal #66

merged 1 commit into from
Feb 6, 2020

Conversation

deepueg
Copy link
Contributor

@deepueg deepueg commented Feb 6, 2020 •
edited
Loading

Fix an issue when a listener/handler is removed before React Native is initialized

Add tests

@deepueg deepueg changed the title Fix an issue when a listener/handler is removed before react native i… Handle event registration and removal Feb 6, 2020
friederbluemle
friederbluemle approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepueg deepueg merged commit a8cb0a2 into electrode-io:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belemaire belemaire belemaire approved these changes

@friederbluemle friederbluemle friederbluemle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepueg @friederbluemle @belemaire