Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external sources #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

friederbluemle
Copy link
Member

@friederbluemle friederbluemle commented Dec 10, 2019

This is a work-in-progress PR (currently does not build).

It removes the copies of all external source files (2x react-native, and react-native-electrode-bridge) from the repository. The goal is to acquire and integrate with external dependencies through a package and/or dependency manager (like other projects).

⚠️ do-not-merge

@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from b3090ae to 5fd713c Compare December 13, 2019 00:24
@liulianci liulianci mentioned this pull request Jan 10, 2020
@friederbluemle
Copy link
Member Author

Nice. After #67 is merged, this PR is down from

2105 files changed, 4547 insertions(+), 236247 deletions(-)

to

1055 files changed, 4547 insertions(+), 118129 deletions(-)

@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from 7245deb to 8d0a94c Compare January 14, 2020 23:00
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 3 times, most recently from 4f8de58 to 7238cdd Compare January 23, 2020 18:31
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 4 times, most recently from e39410f to f3d9076 Compare February 5, 2020 18:18
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 3 times, most recently from cd6bc72 to dfe662e Compare February 24, 2020 18:58
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from db1aac8 to 4cda913 Compare March 6, 2020 21:52
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 3 times, most recently from 0c7fefb to 52baff0 Compare April 13, 2020 16:26
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from 3103909 to 844afda Compare April 22, 2020 08:01
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from 6efb1f0 to 3c08221 Compare April 28, 2020 01:13
@friederbluemle friederbluemle force-pushed the remove-ext-src branch 2 times, most recently from fd725ff to b213dc5 Compare May 7, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant