Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor]: fix props passing when redux load subapp is used #1953

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[minor]: fix props passing when redux load subapp is used #1953

merged 2 commits into from
Mar 2, 2023

Conversation

arunvishnun
Copy link
Contributor

When using reduxLoadSubapp, the custom renderStart function is used. This custom renderStart is not currently handling props

Fix applied to get props from instance and pass it while creating root Component

@arunvishnun arunvishnun merged commit f56df3b into electrode-io:master Mar 2, 2023
@arunvishnun arunvishnun deleted the fix/reduxapp/props branch March 2, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuthya smuthya smuthya approved these changes

@divyakarippath divyakarippath Awaiting requested review from divyakarippath

@chandub chandub Awaiting requested review from chandub

@kylejeske kylejeske Awaiting requested review from kylejeske

@shubham2811 shubham2811 Awaiting requested review from shubham2811

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunvishnun @smuthya