Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies to resolve build issues #1888

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Conversation

smuthya
Copy link
Contributor

@smuthya smuthya commented Jun 2, 2022

With typescript version 4.7.2, tests are failing in webpack-config-composer, xarc-app-dev, xarc-subapp packages. Updated the version of ts-node to fix this.

data-reactroot isn't getting created due to Context.Provider, so removed it from xarc-react test case

enzyme breaks with cheerio version v1.0.0-rc.11, so had to set cheerio to =1.0.0-rc.10 version in samples/stylus-sample, samples/react-jest-app to resolve this issue

Reference :
jestjs/jest#12655
facebook/react#15012
enzymejs/enzyme#2558

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@smuthya smuthya changed the title fix: fix error with ts 4.7.2 version fix: update dependencies to resolve build issues Jun 3, 2022
@smuthya smuthya requested review from chandub and divyakarippath June 3, 2022 23:11
@mristic505
Copy link
Contributor

LGTM

@smuthya smuthya merged commit 60e173d into master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants