Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert webpack config composer to be Typescript #1847

Merged
merged 18 commits into from
Apr 13, 2021

Conversation

zenz34
Copy link
Contributor

@zenz34 zenz34 commented Apr 9, 2021

convert webpack config to be Typescript

----------------------------|---------|----------|---------|---------|-------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 100 100 100 100
concat-method.ts 100 100 100 100
constants.ts 100 100 100 100
delete-custom-props.ts 100 100 100 100
head-concat-array-merge.ts 100 100 100 100
index.ts 100 100 100 100
partial.ts 100 100 100 100
profile.ts 100 100 100 100
tail-concat-array-merge.ts 100 100 100 100
---------------------------- --------- ---------- --------- --------- -------------------

=============================== Coverage summary ===============================
Statements : 100% ( 152/152 )
Branches : 100% ( 87/87 )
Functions : 100% ( 47/47 )
Lines : 100% ( 147/147 )

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zenz34 zenz34 changed the title convert webpack config to be Typescript convert webpack config composer to be Typescript Apr 9, 2021
@zenz34 zenz34 force-pushed the typescript-convert-webpack-config branch from 80fbe68 to 0fd9143 Compare April 9, 2021 23:54
@jchip
Copy link
Member

jchip commented Apr 10, 2021

unit test for xarc-webpack failed

Error: src/index.ts(295,24): error TS2351: This expression is not constructable.
  Type 'typeof import("/home/runner/work/electrode/electrode/packages/xarc-webpack/node_modules/.f/_/webpack-config-composer/1.1.3-fynlocal_h/webpack-config-composer/dist/index")' has no construct signatures.

@jchip jchip closed this Apr 10, 2021
@jchip jchip reopened this Apr 10, 2021
@zenz34 zenz34 force-pushed the typescript-convert-webpack-config branch from 06a84d6 to 9cbfe20 Compare April 12, 2021 16:01
zenz34 added 4 commits April 12, 2021 10:15
solved build errors in webpack
solved test errors in app-dev
solved import errors happend in stylus samples
@jchip jchip merged commit 212c508 into electrode-io:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants