[MINOR] shared routing for subapps #1783
Conversation
|
Durrab Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
update description comments for use |
| @@ -0,0 +1,4 @@ | |||
| import { createBrowserHistory } from "history"; | |||
| export default class RouterHistory { | |||
There was a problem hiding this comment.
this is a bit overkill to create a static value, and no export default
There was a problem hiding this comment.
also, this will trigger createBrowserHistory immediately when app's loaded
| * - Otherwise it's assumed to be a history object and `Router` will be used with it. | ||
| * - If it's false, then `BrowserRouter` will be used and it will use its own history. | ||
| * - Note: BrowserRouter use its own history object and its not shared among other subapps | ||
| * - If it's `true`, then `Router` is used with history from `createBrowserHistory` from https://www.npmjs.com/package/history and the same history object will be shared among all subapps |
There was a problem hiding this comment.
what if history is not specified?
There was a problem hiding this comment.
I mentioned this here in the last line
-
- Otherwise it's assumed to be a history object and
Routerwill be used with it. If its undefined then share history object will be used for all subapps
- Otherwise it's assumed to be a history object and
| @@ -1,9 +1,9 @@ | |||
| import { SubAppDef, SubAppFeatureFactory } from "@xarc/subapp"; | |||
| import { Router, BrowserRouter } from "react-router-dom"; | |||
| import { createBrowserHistory } from "history"; | |||
|
|
|||
| //import RouterHistory from "./router-history" | |||
| import { ReactRouterFeatureOptions, _id, _subId } from "../common"; | ||
|
|
||
| import { createBrowserHistory } from "history"; | ||
| const reactRouterHistory = createBrowserHistory(); |
There was a problem hiding this comment.
I have to have reactRouterHistory on top because reactRouterFeature called multiple times for each sub-app and this is a one time call as shared history object
| @@ -52,7 +52,7 @@ export const subapp: ReactSubApp = { | |||
| reduxFeature({ | |||
There was a problem hiding this comment.
what are these changes in this file for?
There was a problem hiding this comment.
I removed the subapp-web which was not required here - I used it when I was playing with that.
There was a problem hiding this comment.
what does these changes have to do with subapp-web?
| @@ -1,146 +0,0 @@ | |||
| { | |||
| TheRouter = BrowserRouter; | ||
| } else { | ||
| history = options.history === true ? createBrowserHistory() : options.history; | ||
| history = options.history === true ? reactRouterHistory : (options.hasOwnProperty("history") ? options.history : reactRouterHistory); |
There was a problem hiding this comment.
as discussed, the history created in this file is used only if:
options.historyistrueoptions.historyis notdefined
Otherwise,- if it's not
falsy, assume it's a valid history object and use it withRouter - finally use
BrowserRouter
No description provided.