Fix CSS Modules generated scope name based on prod vs dev mode. #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Currently css modules with SSR works only during dev mode. It is because the generated class name during ssr (css-require-hook) vs webpack build uses different generated scope names.
Also, there is strict check for
options.cssModuleHookas boolean but code expects an object to get the generated Scope name from user land. Users won't be able to override the generatedScopeName value.Fix: Allow objects to be passed from users to control options passed to css module require hook and default to short names for production mode.
cc @jchip @divyakarippath