simple node http server for webpack dev #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yisheng Jiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jchip
reviewed
Sep 1, 2020
| @@ -0,0 +1,80 @@ | |||
| /* eslint-disable @typescript-eslint/no-var-requires */ | |||
| export {}; | |||
| @@ -11,6 +12,7 @@ const electrodeServer = optionalRequire("electrode-server"); | |||
| const Hapi = optionalRequire("@hapi/hapi"); | |||
| const Koa = optionalRequire("koa"); | |||
| const express = optionalRequire("express"); | |||
| const http = optionalRequire("http"); | |||
There was a problem hiding this comment.
http is a built-in module, no need to optionalRequire it.
also, use import.
| @@ -20,7 +22,21 @@ if (process.env.WEBPACK_DEV === undefined) { | |||
| process.env.WEBPACK_DEV = "true"; | |||
| } | |||
|
|
|||
| if (fastifyServer) { | |||
| if (http) { | |||
|
CI failed, run |
yishengjiang99
force-pushed
the
839-vanilla-dev-admin
branch
from
a145f00 to
2176861
Compare
fix eslint errors
use import on http
jcaowml
approved these changes
Sep 1, 2020
jcaowml
reviewed
Sep 1, 2020
| import { createServer, IncomingMessage, RequestListener, ServerResponse } from "http"; | ||
| import * as Url from "url"; | ||
| import { resolve } from "path"; | ||
| const Middleware = require("./middleware"); |
There was a problem hiding this comment.
I think middleware is typed, so you can import it normally
jcaowml
reviewed
Sep 1, 2020
| .end(`<!DOCTYPE html>${html}`); | ||
| }, | ||
| replyError: err => { | ||
| res.writeHead(500, err); |
jcaowml
reviewed
Sep 1, 2020
| server.addListener(event.toString(), cb); | ||
| }, | ||
| stop: () => { | ||
| server.close(function() { |
There was a problem hiding this comment.
Since this is asynchronous, it's a good idea to make this return a promise?
jchip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased to