Updates above-the-fold demo + docs #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caoyangs
reviewed
Sep 16, 2016
| Navigate to `<your-electrode-app>/client/components/above-the-fold.jsx.` Following the instructions on how to manipulate the skip prop by directly commenting and uncommenting the `above-the-fold-only-server-render` [component](https://github.com/electrode-io/above-the-fold-only-server-render). | ||
| The best way to demo this existing component is actually going to be in your `node_modules.` | ||
|
|
||
| Navigate to `<your-electrode-app>/node_modules/above-the-fold-only-server-render/components/above-the-fold-only-server-render.js` line 29: |
There was a problem hiding this comment.
components should be under lib folder, can you double check?
/node_modules/above-the-fold-only-server-render/lib/components/above-the-fold-only-server-render.js
There was a problem hiding this comment.
That's right @caoyangs. Updated readme.md with the correct path
jchip
pushed a commit
that referenced
this pull request
Dec 7, 2016
Updates above-the-fold demo + docs
jchip
pushed a commit
that referenced
this pull request
Dec 7, 2016
use shell exported by gulp helper
jchip
added a commit
to jchip/electrode
that referenced
this pull request
Mar 16, 2017
Webpack Reporter Redesign
datvong-wm
pushed a commit
to datvong-wm/electrode
that referenced
this pull request
Sep 5, 2018
update document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.