First pass of an Electrode subapp guide #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikey
reviewed
Jan 17, 2020
| mkdir my-app && cd my-app && npm init -y @xarc/app && npm i && npm run dev | ||
| ``` | ||
|
|
||
| This will create, install, and run an Electrode web application with a few simple subapps. |
There was a problem hiding this comment.
Personally I like when this break down, highlights the command that was used above, so the engineer has context of how the above line was composed.
There was a problem hiding this comment.
I do like that! Would you separate into multiple lines and add comments to each line?
dmikey
reviewed
Jan 17, 2020
docs/guides/subapps.md
Outdated
|
|
||
| - What is a subapp? | ||
|
|
||
| At its core, a subapp is simply a display component. Currently, this can be either or React or Preact component, but more UI libraries may be supported in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no inbound links to this page yet.