Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ce1134 #1474

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Ce1134 #1474

merged 3 commits into from
Dec 20, 2019

Conversation

datvong-wm
Copy link
Contributor

No description provided.

jchip
jchip reviewed Dec 19, 2019
View reviewed changes
packages/electrode-archetype-react-app-dev/lib/webpack-dev-fastify.js
"use strict";
/* eslint-disable no-console, no-magic-numbers */

const fastifyPlugin = require("fastify-plugin");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add this to dependencies

@jchip jchip merged commit 93e967a into electrode-io:next Dec 20, 2019
@datvong-wm datvong-wm deleted the ce1134 branch December 20, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchip jchip jchip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datvong-wm @jchip