set babel env target for dev mode with archetype v5 #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1846689910
changed the title
jchip
reviewed
May 20, 2019
| @@ -25,7 +26,7 @@ module.exports = function(options) { | |||
| targets, | |||
| useBuiltIns: "entry", | |||
| corejs: "2", | |||
| modules: isProduction ? false : "commonjs" | |||
| modules: isProduction || (isDevelopment && target !== "default") ? false : "commonjs" | |||
There was a problem hiding this comment.
I don't get what's going on here. Could you explain it for me please?
| "dev-es6": { | ||
| desc: | ||
| "Start your app with watch in development mode with webpack-dev-server with ENV_TARGET=es6", | ||
| task: ["dev-target-es6", "dev"] |
There was a problem hiding this comment.
task: "dev --target=es6" should work also right? No need for the extra dev-target-es6 task.
There was a problem hiding this comment.
correction: task: ["dev --target=es6"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define
envTargetsinarchetype/config/index.jsuse
clap dev --target=es6or aliasclap dev-es6