fix(throw on missing stats.json) (#1561)

electrode-io · Mar 13, 2020 · bd7f5c4 · bd7f5c4
1 parent b40e304
commit bd7f5c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/subapp-web/lib/util.js b/packages/subapp-web/lib/util.js
@@ -235,7 +235,11 @@ const utils = {
     try {
       stats = JSON.parse(Fs.readFileSync(Path.resolve(statsPath)).toString());
     } catch (err) {
-      return {};
+      throw new Error(
+        `Couldn't find stats.json at ${Path.resolve(
+          statsPath
+        )}. Please ensure environment is set up correctly. (Did you run 'clap dev'?)`
+      );
     }
 
     const assets = {};

diff --git a/packages/subapp-web/test/spec/util.spec.js b/packages/subapp-web/test/spec/util.spec.js
@@ -26,9 +26,10 @@ describe("loadAssetsFromStats", () => {
     expect(assets).to.not.have.own.property("manifest");
   });
 
-  it("should return empty assets if stats.json does not exist", () => {
-    const assets = loadAssetsFromStats("some path");
-    expect(assets).be.empty;
+  it("should throw if stats.json does not exist", () => {
+    expect(
+        () => loadAssetsFromStats("some path")
+    ).to.throw();
   });
 });