Skip to content

Commit

Permalink
add two options for improving webpack performance (#1904)
Browse files Browse the repository at this point in the history
Co-authored-by: Steve Herzog <[email protected]>
  • Loading branch information
SRHerzog and Steve Herzog authored Oct 19, 2022
1 parent abd1175 commit b35a1b4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/xarc-webpack/src/partials/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ module.exports = function() {
filename: `${nsTag}[name].bundle.dev.js`,
chunkFilename: `${nsTag}[name].bundle.dev.js`
},
devtool: "inline-source-map",
devtool: xarcOptions.webpack.devtool || false,
// TODO: why is this here and duplicates what's in extract-style partial? This is causing
// duplicate CSS bundles to be generated in dev mode.
// Comment out for now
Expand Down
3 changes: 3 additions & 0 deletions packages/xarc-webpack/src/partials/isomorphic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { loadXarcOptions } from "../util/load-xarc-options";

module.exports = function(opts) {
const xarcOptions = loadXarcOptions();
if (xarcOptions.webpack.disableSsr) {
return {};
}

const { IsomorphicLoaderPlugin } = xAppRequire("isomorphic-loader");

Expand Down

0 comments on commit b35a1b4

Please sign in to comment.