fix: output subapp v2 info to dist

electrode-io · Oct 14, 2020 · 91d88ea · 91d88ea
1 parent 5a26418
commit 91d88ea
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/packages/xarc-webpack/src/partials/subapp2.ts b/packages/xarc-webpack/src/partials/subapp2.ts
@@ -7,6 +7,12 @@ import { JsonpScriptSrcPlugin } from "../plugins/jsonp-script-src-plugin";
 
 module.exports = function(opts) {
   return {
-    plugins: [new SubAppWebpackPlugin({ webpackVersion: 4 }), new JsonpScriptSrcPlugin()]
+    plugins: [
+      new SubAppWebpackPlugin({
+        webpackVersion: 4,
+        assetsFile: "../subapps.json"
+      }),
+      new JsonpScriptSrcPlugin()
+    ]
   };
 };
diff --git a/packages/xarc-webpack/src/plugins/subapp-plugin.ts b/packages/xarc-webpack/src/plugins/subapp-plugin.ts
@@ -39,15 +39,33 @@ export class SubAppWebpackPlugin {
   _wVer: number;
   _makeIdentifierBEE: Function;
   _tapAssets: Function;
+  _assetsFile: string;
 
   /**
    *
    * @param options - subapp plugin options
    */
   constructor({
     declareApiName = ["declareSubApp", "createDynamicComponent"],
-    webpackVersion = findWebpackVersion()
-  }: { declareApiName?: string | string[]; webpackVersion?: number } = {}) {
+    webpackVersion = findWebpackVersion(),
+    assetsFile = "subapps.json"
+  }: {
+    /**
+     * The API names for declaring subapp and components
+     */
+    declareApiName?: string | string[];
+    /**
+     * Webpack version (4, 5, etc)
+     *
+     * minimum 4
+     */
+    webpackVersion?: number;
+    /**
+     * Filename to output the subapp assets JSON file
+     * **default**: `subapps.json`
+     */
+    assetsFile?: string;
+  } = {}) {
     this._declareApiNames = [].concat(declareApiName);
     this._subApps = {};
     this._wVer = webpackVersion;
@@ -56,6 +74,7 @@ export class SubAppWebpackPlugin {
 
     this._makeIdentifierBEE = makeIdentifierBEE;
     this._tapAssets = tapAssets;
+    this._assetsFile = assetsFile;
   }
 
   initWebpackVer4() {
@@ -104,7 +123,7 @@ export class SubAppWebpackPlugin {
       );
     }
     const subapps = JSON.stringify(subappMeta, null, 2) + "\n";
-    assets["subapps.json"] = {
+    assets[this._assetsFile] = {
       source: () => subapps,
       size: () => subapps.length
     };