Add option for reduxStoreReady for subapp pbundle (#1507)

* Add option for reduxStoreReady for subapp pbundle * Do not pass all of "this": only the store * Do not use preact hydrate
electrode-io · Jan 23, 2020 · 55ebfb0 · 55ebfb0
1 parent 93206c5
commit 55ebfb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/packages/subapp-pbundle/lib/framework-lib.js b/packages/subapp-pbundle/lib/framework-lib.js
@@ -125,6 +125,10 @@ class FrameworkLib {
       this.store,
       `redux subapp ${subApp.name} didn't provide store, reduxCreateStore, or reducers`
     );
+    const reduxStoreReady = subAppServer.reduxStoreReady || subApp.reduxStoreReady;
+    if (reduxStoreReady) {
+      await reduxStoreReady({store: this.store});
+    }
     if (options.serverSideRendering === true) {
       assert(Provider, "subapp-web: react-redux Provider not available");
       // finally render the element with Redux Provider and the store created

diff --git a/packages/subapp-pbundle/src/redux-bundler.jsx b/packages/subapp-pbundle/src/redux-bundler.jsx
@@ -13,21 +13,12 @@ export function reduxRenderStart(options) {
   const store = options._store || options.reduxCreateStore(options.initialState);
   const { Component } = options;
 
-  if (options.serverSideRendering) {
-    hydrate(
-      <Provider store={store}>
-        <Component />
-      </Provider>,
-      options.element
-    );
-  } else {
-    render(
-      <Provider store={store}>
-        <Component />
-      </Provider>,
-      options.element
-    );
-  }
+  render(
+    <Provider store={store}>
+      <Component />
+    </Provider>,
+    options.element
+  );
 
   return store;
 }