Skip to content

Commit

Permalink
Fix for non-string (numeric) subapp bundle ids (#1515)
Browse files Browse the repository at this point in the history
  • Loading branch information
christianlent authored Jan 29, 2020
1 parent 94213d4 commit 5137506
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/subapp-web/src/subapp-web.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@

markBundlesLoaded(ids) {
[].concat(ids).forEach(id => {
xv1.setBundle(id, 1);
xv1.setBundle(id.toString(), 1);
});
},

Expand Down Expand Up @@ -180,8 +180,8 @@
}, a);
}, [])
.filter(({ id }) => {
if (xv1.getBundle(id) === undefined) {
xv1.setBundle(id, 0); // mark as loading
if (xv1.getBundle(id.toString()) === undefined) {
xv1.setBundle(id.toString(), 0); // mark as loading

return true;
}
Expand Down

0 comments on commit 5137506

Please sign in to comment.